search

pharo-project / pharo-launcher

Lets you manage your pharo images and download new ones
https://pharo-project.github.io/pharo-launcher/
MIT License
109 stars 46 forks source link

Image create from repository ends up with error, when version is specified in argument #646

Closed Bajger closed 10 months ago

Bajger commented 10 months ago

Describe the bug Specifying version in project name do not work, when creating image from GH project

To Reproduce Steps to reproduce the behavior:

  1. Run: ./pharo-launcher image create fromRepo --newImageName RoassalPlayground pharo-graphics/Roassal:v1.05b
  2. See error: PhLError: Invalid repository name: pharo-graphics/Roassal:v1.05b. Please specify in {owner}/{project} or {owner}/{project}:{feature}/{branch-name} format

Expected behavior Project is loaded successfully into new image.

Version information:

Expected development cost Fix regex checking repo name to consume version tag as well. See: PhLImageCreateFromRemoteRepoCliCommand >> regexForRepoName

Additional context Reported by user on Discord: https://discord.com/channels/223421264751099906/1191849727046734024/1195796060321353728