pharo-launcher vm list throws an error on Linux

[demarey]

pharo-launcher vm list throws an error on Linux (fgrep is obsolescent, use grep -F)

[estebanlm]

(fgrep is obsolescent, use grep -F) this is not the error, is just a warning of the script :)

[Bajger]

I tried to reproduce bug and executed vm list on Ubuntu, but works on my environment.

1. 'fgrep' is not part of Pharo launcher source code. (looked for 'method source with it')

2. Problem probably in obtaining of pharo version, most probably returns nil on particular (some old?) vm:

   PhLVmProvider class>>for:
   for: aPhLVirtualMachineOrManager
   | class |
   class := aPhLVirtualMachineOrManager pharoVersion asInteger < 90
       ifTrue: [ PhLVmProviderUntilPharo80 ]
       ifFalse: [ self ].
   
   ^ class new
       vmManager: aPhLVirtualMachineOrManager;
       yourself.

[Bajger]

What about using:

| class vmVersion|
        vmVersion := aPhLVirtualMachineOrManager pharoVersion.
    class := (vmVersion isNil or: [vmVersion asInteger < 90])
        ifTrue: [ PhLVmProviderUntilPharo80 ]
        ifFalse: [ self ].

    ^ class new
        vmManager: aPhLVirtualMachineOrManager;
        yourself.

@demarey What do you think? Is it systematic or we should trace down, why pharoVersion returns nil.

[demarey]

@estebanlm could you open the file ~/pharo/launcherSettings.ston (should be that on linux), check the value of vmsDirectory and give us the result of ls -R on this folder ?