pharo-project / pharo-launcher

Lets you manage your pharo images and download new ones
https://pharo-project.github.io/pharo-launcher/
MIT License
109 stars 46 forks source link

Progress bar displays "StringMorph" #669

Open jecisc opened 9 months ago

jecisc commented 9 months ago

I took the development PharoLauncher and when I'm creating a new image (I took the P12 64bit development image) I get some "StringMorph" displayed in the progress bar:

image

Pharo Launcher version: 3.1.1-404-gef2c9dbc

Bajger commented 9 months ago

Relates to PR: https://github.com/pharo-project/pharo-launcher/pull/608 Probably due to migration from P10 to P11

demarey commented 9 months ago

This is strange. I cannot reproduce it even by taking the same version you reported: https://github.com/pharo-project/pharo-launcher/actions/runs/7584839224

GitHub
Allow to define a short name on templates and create an image from th… · pharo-project/pharo-launcher@ef2c9db
Lets you manage your pharo images and download new ones - Allow to define a short name on templates and create an image from th… · pharo-project/pharo-launcher@ef2c9db
guillep commented 9 months ago

I think we should wait until Pharo12 stabilises a bit here :)

demarey commented 9 months ago

yes, but PL uses P11, so it should work. The progress comes from PL and not the launched image.

guillep commented 9 months ago

@jecisc 's screenshot and his comments makes me think he got (somehow) a pharo launcher running on top of a latest P12 :)

jecisc commented 9 months ago

The P12 image was the one that was been downloaded by the PL :) But I took the PL provided at the meeting about the PL-CLI. That is in P11 IIRC

guillep commented 9 months ago

Well I confirm I saw the bug in Launcher 3.1.1-418-ge2eb5da2

Bajger commented 9 months ago

Can we extend jobPresenterHeight? I think it could be because of different zoom ratio on OS: https://github.com/pharo-project/pharo-launcher/pull/608/files#diff-c99ee8b0d96b24723c910c09ac3b07cf39c7dd347af2b6c1eafa5f4481e26868R6

GitHub
595 general progress bar by Bajger · Pull Request #608 · pharo-project/pharo-launcher
fixes #595 There is unrelated commit on SpConfirmDialog, but I've included that.