search

pharo-project / pharo-vm

This is the VM used by Pharo
http://pharo.org
Other
113 stars 68 forks source link

small change to fix locals having the same name as methods causing conflicts during inlining #841

Closed RenaudFondeur closed 1 month ago

RenaudFondeur commented 1 month ago

fix all current Slang warning in the form of 'Local variable name 'variable' in selector may mask method when inlining'

add an '_' to the concerned variables.

guillep commented 1 month ago

Hi @RenaudFondeur , I don't like this change ^^.

This should be automatically done by slang. I want to write Pharo code normally :)

guillep commented 1 month ago

As talked with @RenaudFondeur this should be done in a different way. I'll close this issue.

PalumboN commented 1 month ago

Maybe the Ivo's work about renaming conflicting identifiers could help as inspiration: https://github.com/pharo-project/pharo-vm/pull/646