pharo-project / pharo-zeroconf

ZeroConf script generator for http://get.pharo.org
16 stars 15 forks source link

pharo-ui wrapper script of headless VMs is broken #20

Closed cdlm closed 4 years ago

cdlm commented 5 years ago

Happens with at least get.pharo.org/64/vmHeadlessLatest80 from 2019-09-11.

All command-line arguments get concatenated into one; this breaks probably all command line handlers when running with pharo-ui. The headless wrapper hasn't been "refactored" so it still works.

This is due to the intermediate $image_arguments variable on the last line instead of directly using "$@" (which has different expansion semantics to normal variables, welcome to Bash…)

estebanlm commented 5 years ago

duh! My bad :P This is because I needed to add the --interactive parameter and well, I screwed it. Can you propose an alternative script? Thanks!

cdlm commented 5 years ago

Just remove the image_arguments initialization and and replace last line with

"$DIR"/"pharo-vm/Pharo.app/Contents/MacOS/Pharo" "$image_name" --interactive "$@"

BTW I couldn't find where the original source for those scripts is…

cdlm commented 4 years ago

☕️

cdlm commented 4 years ago

now when does that become available ?