Add windows batch compatibility

VincentBlondeau commented 4 years ago

This PR aims to add a support for batch (native windows console) for ZeroConf. The files are still the same but the few lines at the beginning allow to choose between Win and Unix.

Only images >= Pharo7 can be downloaded properly. (I do not plan to implement it for lower versions).

Testing can be done locally with this piece of code:

AbstractZeroConfBashScript compile: 'baseUrl
    ^ ''http://localhost:4567/'' asZnUrl'.
ZeroConfCommandLineHandler generateInDirectory: 'GeneratedFiles' asFileReference 
.
server := ZnServer on: 4567.
(staticFileServerDelegate := ZnStaticFileServerDelegate new)
    prefixFromString: ''; 
    directory: 'GeneratedFiles' asFileReference ;
    mimeTypeExpirations: ZnStaticFileServerDelegate defaultMimeTypeExpirations. 
server delegate: staticFileServerDelegate.
server start.

Developed and tested for Windows 10 x64 and Firefox.

svenvc commented 4 years ago

Nice and important initiative, I hope you manage to avoid breaking things ..

VincentBlondeau commented 4 years ago

Thanks @svenvc ! I cannot try on all the unix's so if you can test locally it will be great! (and the tests are not running on windows too.....)

VincentBlondeau commented 4 years ago

I also made a bit of refactoring to use the fileBaseUrl instead of hardcoded values

VincentBlondeau commented 3 years ago

This PR has not been integrated and is now in conflict with the latest changes... Is there anything blocking this?

guillep commented 3 years ago

I'll take a look!!

VincentBlondeau commented 2 years ago

Is it possible to have this PR fixed for Pharo 10?

VincentBlondeau commented 6 days ago

Giving up. This code is too old to be merged.

pharo-project / pharo-zeroconf

Add windows batch compatibility #21