search

pharo-project / pharo-zeroconf

ZeroConf script generator for http://get.pharo.org
16 stars 15 forks source link

Don't set repository. #4

Closed peteruhnak closed 8 years ago

peteruhnak commented 8 years ago

Minor change that removes spec repository: 'filetree://repository/mc'., because this breaks down when the project is loaded from someone else's ConfigurationOf.

And merged in the commandShell method, because no point in having an extra method.

estebanlm commented 8 years ago

is ok, but why did you remove #commandShell: method and merged it with baseline? (and btw... we should deprecate configuration and make a baseline from this)

peteruhnak commented 8 years ago

Because it looks odd. I've never seen such appropach in any Baseline/Configuration so it appears confusing. I can change it back if you want.

On Sun, Jun 05, 2016 at 06:13:13AM -0700, Esteban Lorenzano wrote:

is ok, why did you remove #commandShell: method and merged it with baseline? (and btw... we should deprecate configuration and make a baseline from this)

You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/pharo-project/pharo-zeroconf/pull/4#issuecomment-223812401

estebanlm commented 8 years ago

How so? all baselines I uses/working on plus the versioner template suggest this approach... and all the baselines I work on uses them. EDIT: Not the best writing ever, I'm sleepy and dispersed, but you get the point :)

peteruhnak commented 8 years ago

I've reverted that particular change. I've just never seen such approach, so I guess I have some studying to do. :)