iceberg commit window is cutting "commit" button

[estebanlm]

Bug description When you open a commit window and the active branch is other than "master" (or other small name), the window contents is larger than the window size, pushing the button out (and giving a bad look and feel).

To Reproduce Steps to reproduce the behavior:

1. Create a pharo branch bigger than master (e.g. "issue-X-iceberg-commit-window-is-cutting-commit-button").
2. make a random change and open commit window

Expected behavior Contents should be arranged taking into account the window size (and in the case of the branch size, it should be cut to a maximum of chars to allow regular size to be shown).

Screenshots

[guillep]

Maybe we should add an ellipsis for now to limit the size of the branch label? Something like issue-X-iceberg-...mmit-button

[estebanlm]

yep, that's what was thinking on.

On Dec 7 2021, at 4:27 pm, Guille Polito @.***> wrote:

Maybe we should add an ellipsis for now to limit the size of the branch label? Something like issue-X-iceberg-...mmit-button

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub (https://github.com/pharo-project/pharo/issues/10559#issuecomment-988031115), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AAD5MXX26GTJV4SVRUD4OTDUPYRUPANCNFSM5JDYHPHQ). Triage notifications on the go with GitHub Mobile for iOS (https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675) or Android (https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub).

[kasperosterbye]

This has a very simple solution I am ashamed not to have seen before - place the Commit button to the left.

Code change in IceTipCommentPanel>>#intializePresenters by adding placeAtStart:

actionButtonBar := self newButtonBar.
    actionButtonBar placeAtStart; add: (commitButton := sel...

The issue already exist in Icebert repository: https://github.com/pharo-vcs/iceberg/issues/1571

[kasperosterbye]

There is a PR on the iceberg repo (https://github.com/pharo-vcs/iceberg/pull/1627)

[MarcusDenker]

This is now fixed