Cleanup: Prefix change from "RB" to "AST" for Abstract syntax tree related classes

[astares]

From the historic point of view Smalltalk started I guess Smalltalk refactorings had their roots in the Refactoring Browser (RB) and can be traced back to work at UIUC (University of Illinois, Urbana-Champaign) by Don Roberts, John Brant, and Ralph Johnson

• https://wiki.c2.com/?RefactoringBrowser
• https://refactory.com/refactoring-browser
• https://www.researchgate.net/publication/220346807_A_Refactoring_Tool_for_Smalltalk

Following this history the classes like RBNode had an "RB" prefix for RefactoringBrowser.

But logically now in newer Pharo we have put them into packages for "AST" - Abstract Syntax Tree

If you think about it for a while it would be more logically to have them prefixed with "AST" instead of "RB". Yes - we know it is heritic and means effort and deprecation/transition/migration - but for Pharo we want to constantly improve, get clean and do for the better.

Additionally this would also help people who are comming from other (more mainstream) languages to find it in alignment with the AST concepts and namings there.

[astares]

Look: That cleanup had already been stated as a TODO in the class comment of RBNode which reflects the superclass for all classes represening AST Nodes (not RB nodes)

[astares]

Also a renaming of classes like RBParser into ASTParser would give a proper and more intention revealing name. At the moment the class comment says: "RBParser takes a source code string and generates an AST for it". We do not parse an "RB" - we parse source code and create an AST. So the name is somehow misleading.

[astares]

A possible way to do such a cleanup could be (if we have a class RBxxxx):

• we rename a class RBxxxx into ASTxxxx
• we create an empty and also deprecated subclass RBxxxx as a subclass of ASTxxxx into the system so that (extern) code which is dependent on old names can still be loaded
• the deprecated RBxxxx classes should go into a "DeprecatedPharo..." package
• after one Pharo iteration we could remove the deprecated classes as usual

[Ducasse]

I agree :) Now we should plan it for P11. Or we can do it by having RB* as subclasses of their AST counterparts for now

[astares]

"AST-Core" Package

class category "Formatter"

RBSimpleFormatter -> ASTSimpleFormatter

class category "Matching"

RBParseTreeRule -> ASTParseTreeRule RBReplaceRule -> ASTReplaceRule RBBlockReplaceRule -> ASTBlockReplaceRule RBStringReplaceRule -> ASTStringReplaceRule RBSearchRule -> ASTSearchRule RBParseTreeSearcher -> RBParseTreeSearcher RBParseTreeRewriter -> ASTParseTreeRewriter

class category "Nodes"

RBNode -> ASTNode RBProgramNode -> ASTProgramNode RBComment -> ASTComment RBMethodNode -> ASTMethodNode RBPragmaNode -> ASTPragmaNode RBReturnNode -> ASTReturnNode RBSequenceNode -> ASTSequenceNode RBValueNode -> ASTValueNode RBArrayNode -> ASTArrayNode RBAssignmentNode -> ASTAssignmentNode RBBlockNode -> ASTBlockNode RBCascadeNode -> ASTCascadeNode RBLiteralNode -> ASTLiteralNode RBLiteralArrayNode -> ASTLiteralArrayNode RBLiteralValueNode -> ASTLiteralValueNode RBMessageNode -> ASTMessageNode RBSelectorNode -> ASTSelectorNode RBVariableNode -> ASTVariableNode RBStringReplacement -> ASTStringReplacement

class category "Nodes - ErrorNodes"

RBParseErrorNode -> ASTParseErrorNode RBEnglobingErrorNode -> ASTEnglobingErrorNode RBArrayErrorNode -> ASTArrayErrorNode RBBlockErrorNode -> ASTBlockErrorNode RBInvalidCascadeErrorNode -> ASTInvalidCascadeErrorNode RBLiteralArrayErrorNode -> ASTLiteralArrayErrorNode RBLiteralByteArrayErrorNode -> ASTLiteralByteArrayErrorNode RBMissingOpenerErrorNode -> ASTMissingOpenerErrorNode RBParenthesesErrorNode -> ASTParenthesesErrorNode RBPragmaErrorNode -> ASTPragmaErrorNode RBTemporariesErrorNode -> ASTTemporariesErrorNode RBUnfinishedStatementErrorNode -> ASTUnfinishedStatementErrorNode RBUnreachableStatementErrorNode -> ASTUnreachableStatementErrorNode

class category "Parser"

RBParser -> ASTParser RBPatternParser -> ASTPatternParser RBScanner -> ASTScanner RBPatternScanner -> ASTPatternScanner

class category "Pattern"

RBPatternBlockNode -> ASTPatternBlockNode RBPatternWrapperBlockNode -> ASTPatternWrapperBlockNode RBPatternMessageNode -> ASTPatternMessageNode RBPatternMethodNode -> ASTPatternMethodNode RBPatternPragmaNode -> ASTPatternPragmaNode RBPatternVariableNode -> ASTPatternVariableNode

class category "Tokens"

RBToken -> ASTToken RBAssignmentToken -> ASTAssignmentToken RBShortAssignmentToken -> ASTShortAssignmentToken RBEOFToken -> ASTEOFToken RBValueToken -> ASTValueToken RBBinarySelectorToken -> ASTBinarySelectorToken RBCommentToken -> ASTCommentToken RBErrorToken -> ASTErrorToken RBIdentifierToken -> ASTIdentifierToken RBKeywordToken -> ASTKeywordToken RBLiteralArrayToken -> ASTLiteralArrayToken RBLiteralToken -> ASTLiteralToken RBMultiKeywordLiteralToken -> ASTMultiKeywordLiteralToken RBNumberLiteralToken -> ASTNumberLiteralToken RBPatternBlockToken -> ASTPatternBlockToken RBSpecialCharacterToken -> ASTSpecialCharacterToken

class category "Visitors"

RBProgramNodeVisitor -> ASTProgramNodeVisitor RBAbstractBlockVisitor -> ASTAbstractBlockVisitor RBCommentNodeVisitor -> ASTCommentNodeVisitor RBGenericNodeVisitor -> ASTGenericNodeVisitor RBParseErrorNodeVisitor -> ASTParseErrorNodeVisitor RBDumpVisitor -> ASTDumpVisitor RBReadBeforeWrittenTester -> ASTReadBeforeWrittenTester

"ClassParser" package

class category "Model"

RBSlotInitializationNode -> ASTSlotInitializationNode

[astares]

"AST-Core-Tests" Package

class category "Formatter"

RBFormatterTest -> ASTFormatterTest

class category "Matching"

RBParseTreeRewriterTest -> ASTParseTreeRewriterTest RBParseTreeSearcherTest -> ASTParseTreeSearcherTest

class category "Nodes"

RBCommentTest -> ASTCommentTest RBMessageNodeTest -> ASTMessageNodeTest RBMethodNodeTest -> ASTMethodNodeTest RBParseErrorNodeTest -> ASTParseErrorNodeTest RBProgramNodeTest -> ASTProgramNodeTest RBSequenceNodeTest -> ASTSequenceNodeTest RBVariableNodeTest -> ASTVariableNodeTest

class category "Parser"

NumberParsingTest -> ASTNumberParsingTest RBParseTreeTest -> ASTParseTreeTest RBParserTest -> ASTParserTest RBErrorNodeParserTest -> ASTErrorNodeParserTest RBPatternParserTest -> ASTPatternParserTest RBScannerTest -> ASTScannerTest

class category "Visitors"

RBCommentNodeVisitorTest -> ASTCommentNodeVisitorTest RBDumpVisitorTest -> ASTDumpVisitorTest RBGenericNodeVisitorTest -> ASTGenericNodeVisitorTest RBReadBeforeWrittenTesterTest -> ASTReadBeforeWrittenTesterTest

deleted unused RASTTest

[astares]

"AST-Core-Traits" Package

TRBProgramNodeVisitor -> ASTTProgramNodeVisitor

[jecisc]

In order to rename the classes we should keep the old names using the new deprecated aliases feature of Pharo 12.

[pavel-krivanek]

while there is a newer issue handling this, what about to close this one?