search

pharo-project / pharo

Pharo is a dynamic reflective pure object-oriented language supporting live programming inspired by Smalltalk.
http://pharo.org
Other
1.19k stars 353 forks source link

3 "Broken Methods" window opens when RBMoveInstanceVariableToClassParametrizedTest is run and green #12223

Open astares opened 1 year ago

astares commented 1 year ago

Go and run RBMoveInstanceVariableToClassParametrizedTest directly in Calypso, the test passes but it also opens a window saying something about 3 "Broken Methods".

image

The window seems to be opened by RBMoveInstVarToClassRefactoring>>#transform

Usually when checks pass nothing should be left - so we should check why the window is opened

fmqa commented 1 year ago

Duplicate of #11834 ?

Ducasse commented 1 year ago

I will check when I get time. Tests should not open windows. What a strange idea.

astares commented 1 year ago

@Ducasse It is not the test who is opening the window. Its the refactoring.

Ducasse commented 1 year ago

Ah indeed yes we are working on that with balsa (revisiting all the refactorings and removing all the popups).