search

pharo-project / pharo

Pharo is a dynamic reflective pure object-oriented language supporting live programming inspired by Smalltalk.
http://pharo.org
Other
1.2k stars 355 forks source link

The banning of a rule for the whole image doesn't work #12513

Open pavel-krivanek opened 1 year ago

pavel-krivanek commented 1 year ago

Bug description The banning of a QA rule for the whole image doesn't work

To Reproduce Steps to reproduce the behavior:

  1. Go to AIGraphAlgorithm>>#findBinaryBlock:
  2. you may see "Utility methods" QA notification.
  3. click on X (Ban this rule)
  4. Select The whole image
  5. no effect, the same for other rules and methods
pavel-krivanek commented 1 year ago

The action runs the ReImageRuleBaner which sets the rule as disabled using ReAbstractRule class>>#enabled:. See ReUtilityMethodsRule enabled

It looks like the rule enablement state is then simply not checked when the rule is applied.