search

pharo-project / pharo

Pharo is a dynamic reflective pure object-oriented language supporting live programming inspired by Smalltalk.
http://pharo.org
Other
1.19k stars 353 forks source link

Cleanup: Condense Sindarin packages #12648

Open astares opened 1 year ago

astares commented 1 year ago 
cms := CompiledMethod allInstances select: [:each |
each package ifNil: [ false ] ifNotNil: [:p |
    p name beginsWith: 'Sindarin' ] ].

cms do: [:cm |
    ((RBRefactoryChangeFactory instance)
         addMethodSource: (ReMethodSourceCleaner clean: cm sourceCode) in: cm origin) execute ]
astares commented 1 year ago

Can not be fixed in Pharo repo - as Sindarin source seems to be loaded from "outside" (external repo) So we need to change it in https://github.com/pharo-spec/ScriptableDebugger I guess

StevenCostiou commented 1 year ago

Indeed it should be made in the ScriptableDebugger repository. I do not see it, has it been merged already? In that case we can close the issue.

astares commented 1 year ago

I will open a PR in https://github.com/pharo-spec/ScriptableDebugger and link it from here. Leave this issue open here for now as a reminder.

GitHub
GitHub - pharo-spec/ScriptableDebugger
Contribute to pharo-spec/ScriptableDebugger development by creating an account on GitHub.