search

pharo-project / pharo

Pharo is a dynamic reflective pure object-oriented language supporting live programming inspired by Smalltalk.
http://pharo.org
Other
1.19k stars 353 forks source link

[CI] Failing tests on the CI: Sindarin #15964

Closed MarcusDenker closed 7 months ago

MarcusDenker commented 8 months ago

Bug description These tests are failing: 

osx-64 / Tests-osx-64 / testIsExecutionFinished – MacOSX64.Sindarin.Tests.SindarinDebuggerTest
osx-64 / Tests-osx-64 / testStepOverFinishedExecution – MacOSX64.Sindarin.Tests.SindarinDebuggerTest
hernanmd commented 7 months ago

A PR in https://github.com/pharo-spec/ScriptableDebugger/pull/89

MarcusDenker commented 7 months ago

The PR was merged, but sindarin tests are still failing on the CI:

The PR was merged in master, maybe we load another branch in Pharo12?

guillep commented 7 months ago

Yes, we load Pharo12 branch. No merges should be done in master.

hernanmd commented 7 months ago

I've seen https://github.com/pharo-spec/ScriptableDebugger/tree/Pharo12 is 3 commits behind master. Do you want me to re-send the PR to Pharo12 branch in ScriptableDebugger?

GitHub
GitHub - pharo-spec/ScriptableDebugger at Pharo12
Contribute to pharo-spec/ScriptableDebugger development by creating an account on GitHub.
jecisc commented 7 months ago

I fast forwarded P12 to master.

I don't know if the change to master should be reverted or not tho

MarcusDenker commented 7 months ago

Fixed!