search

pharo-project / pharo

Pharo is a dynamic reflective pure object-oriented language supporting live programming inspired by Smalltalk.
http://pharo.org
Other
1.21k stars 356 forks source link

Repository cloning no longer shows progress bars #16996

Open Rinzwind opened 3 months ago

Rinzwind commented 3 months ago

In Pharo 13 (build 175), cloning a repository doesn’t show any progress bar, unlike in Pharo 8 (build 1124) in which progress bars are shown for the ‘fetching’ and ‘checking out’ steps:

https://github.com/user-attachments/assets/7709dfe6-d862-4280-b796-8c1a74862caa

Cloning is also faster in Pharo 8: I get around 100 seconds for cloning the ‘pharo’ repository in Pharo 13 versus around 50 seconds in Pharo 8 (which is still quite a bit longer than the 12 seconds ‘git clone’ takes though, see issue #16243).

Rinzwind commented 3 months ago

For comparison: in Pharo 9 through 11, only the non-progressing progress bar ‘Cloning repository […]’ is shown (see issue #13719) and cloning takes about 60 seconds; in Pharo 12, no progress bar at all is shown and cloning takes about 100 seconds.

Rinzwind commented 3 months ago

I traced the timing difference between Pharo 11 and 12 to a specific build: in Pharo 12 build 1395, cloning the ‘pharo’ repository takes around 100 seconds while in build 1394 it takes around 50 seconds. In both builds, the non-progressing progress bar ‘Cloning repository […]’ is shown. Interestingly, in build 1394, progress bars for ‘fetching’ and ‘checking out’ are also shown but only after cloning is already finished:

The timing difference is presumably due to the changes in pull request #16072.

guillep commented 3 months ago

Good catch!