pharo-project / pharo

Pharo is a dynamic reflective pure object-oriented language supporting live programming inspired by Smalltalk.
http://pharo.org
Other
1.21k stars 355 forks source link

Names of some icons are still prefixed by #glamorous #17017

Open Rinzwind opened 2 months ago

Rinzwind commented 2 months ago

In Pharo 13 build 190, the names of some icons are still prefixed by #glamorous, which doesn’t make much sense anymore since the removal of Glamour and GTTools in Pharo 10. As indicated by @Ducasse in pharo-icon-packs pull request #14, the reference should preferably be removed.

To find methods that refer to icon names prefixed by #glamorous, this snippet can be used:

(((ThemeIcons current allIconNames select: [ :name | name beginsWith: 'glamorous' ])
    collect: [ :name |
        name -> ((SystemNavigation default allReferencesTo: name)
            sortedAs: [ :method | method name ]) ])
    as: Dictionary) select: [ :methods | methods notEmpty ]

Note that on StPharoDefaultIconProvider, #initializeSynonyms gives synonyms for some of these icon names.

Ducasse commented 2 months ago

Tx!