pharo-project / pharo

Pharo is a dynamic reflective pure object-oriented language supporting live programming inspired by Smalltalk.
http://pharo.org
Other
1.21k stars 355 forks source link

Enhance "Implementors tool" with Column names #17103

Closed NicolasAnquetil closed 1 month ago

NicolasAnquetil commented 1 month ago

image

The "implementors window" could have titles for the columns, because in the case of long class name as here, it is impossible to know where the class name ends and where the method name starts...

Rinzwind commented 1 month ago

Related issue: issue #13802.

hernanmd commented 1 month ago

As it happens with many tools in Pharo today: We have a tool that will be discarded (based on Morphic and Calypso), difficult to understand, to modify, etc. And we have a new incomplete one (see screenshot below).

The old version is mostly implemented using ClyMessageSendersQuery and ClyMessageImplementorsQuery. The new version is based on NewTools StMessageBrowser, includes collapsible columns, and messages are displayed hierarchically.

Advantage:

Disadvantages:

I will push a PR to replace the senders and implementors launched from Calypso, to use the new StMessageBrowser.

hernanmd commented 1 month ago

In https://github.com/pharo-spec/NewTools/pull/841

Rinzwind commented 1 month ago

@hernanmd I’m confused because the first demo in the pull request, in which you open the implementors of #at: from a System Browser, seems to show StMessageBrowser being used as the default, but in Pharo 13 build 262 the default is still ClyOldMessageBrowserAdapter and setting StMessageBrowser as the default through #beDefaultBrowser causes a MessageNotUnderstood when opening the implementors.