search

pharo-project / pharo

Pharo is a dynamic reflective pure object-oriented language supporting live programming inspired by Smalltalk.
http://pharo.org
Other
1.21k stars 355 forks source link

[CI] test timeout WIN SocketStreamTest #17244

Open MarcusDenker opened 3 weeks ago

MarcusDenker commented 3 weeks ago

On the new win CI, we have these test timing on:

Windows64.Network.Tests.SocketStreamTest.testUpToAfterCloseNonSignaling windows-64 / Tests-windows-64 / Windows64.Network.Tests.SocketStreamTest.testUpToAfterCloseSignaling windows-64 / Tests-windows-64 / Windows64.Network.Tests.SocketStreamTest.testUpToAllAfterCloseNonSignaling windows-64 / Tests-windows-64 / Windows64.Network.Tests.SocketStreamTest.testUpToAllAfterCloseSignaling

MarcusDenker commented 2 weeks ago

They are timing out

I think this started happening after switching to the new CI machine

MarcusDenker commented 2 weeks ago

e.g.

TestTookTooMuchTime
Process>>pvtSignal:list:
[self schedule.
    "It is critical that the following has no suspension point so that
    the test and the wait primitive are atomic. In addition, if the delay
    is no longer being waited on while entering the way we know that it
    is expired because the delay has already fired."
    beingWaitedOn
        ifTrue:[delaySemaphore wait]
        ifFalse:[expired := true]] in DelayWaitTimeout>>wait
FullBlockClosure(BlockClosure)>>ensure:
DelayWaitTimeout>>wait
Semaphore>>waitTimeoutMilliseconds:
Socket>>waitForDisconnectionFor:
Socket>>closeAndDestroy:
SocketStream>>close
SocketStreamTest>>testUpToAfterCloseSignaling
SocketStreamTest(TestCase)>>performTest
MarcusDenker commented 2 weeks ago

This would be a case where skipping the tests on the CI for win (and keeping this issue of course open) could be an idea