Open Gabriel-Darbord opened 3 weeks ago
I am not an English native speaker, yet I believe both are correct? https://www.merriam-webster.com/dictionary/parameterize https://www.oed.com/search/dictionary/?scope=Entries&q=parametrize It would still be nice to use the same form in all the cases.
Describe the problem With SUnit, we can create parameterized tests using
ParametrizedTestCase
. The issue is that parametrized is not a word that exists, it should be parameterized.Classes involved This affects 62 classes, and fortunately no methods (both in Pharo 12 and 13). Out of those, 4 are the original culprits from SUnit:
ParametrizedTestCase
,ParametrizedTestMatrix
,ParametrizedTestExpandedParameter
, andParametrizedTestOption
. The other 58 classes are test classes: 57 in Refactoring and 1 in Roassal.List of classes
ParametrizedTestCase ParametrizedTestExpandedParameter ParametrizedTestMatrix ParametrizedTestOption RBAbstractClassVariableParametrizedTest RBAbstractInstanceVariableParametrizedTest RBAddClassVariableTransformationParametrizedTest RBAddInstanceVariableParametrizedTest RBAddMethodTransformationParametrizedTest RBAddParameterParametrizedTest RBAddTemporaryVariableParametrizedTest RBAddVariableAccessorsParametrizedTest RBAddVariableAccessorsWithLazyInitializationParametrizedTest RBChildrenToSiblingsParametrizedTest RBCopyPackageParametrizedTest RBDeprecateClassParametrizedTest RBDeprecateMethodParametrizedTest RBExtractSetUpMethodAndOccurrencesParametrizedTest RBExtractSetUpMethodParametrizedTest RBExtractToTemporaryParametrizedTest RBFindAndReplaceParametrizedTest RBFindAndReplaceSetUpParametrizedTest RBInlineAllMethodParametrizedTest RBInlineMethodFromComponentParametrizedTest RBInlineMethodParametrizedTest RBInlineParameterParametrizedTest RBInlineTemporaryParametrizedTest RBInsertClassParametrizedTest RBMakeClassAbstractParametrizedTest RBMergeInstanceVariableIntoAnotherParametrizedTest RBMoveInstanceVariableToClassParametrizedTest RBMoveMethodParametrizedTest RBMoveMethodToClassParametrizedTest RBMoveMethodToClassSideParametrizedTest RBMoveVariableDefinitionParametrizedTest RBProtectInstanceVariableParametrizedTest RBPullUpClassVariableParametrizedTest RBPullUpInstanceVariableParametrizedTest RBPullUpMethodParametrizedTest RBPushDownClassVariableParametrizedTest RBPushDownInstanceVariableParametrizedTest RBPushDownMethodParametrizedTest RBRealizeClassParametrizedTest RBRemoveAllSendersParametrizedTest RBRemoveClassVariableParametrizedTest RBRemoveInstanceVariable2ParametrizedTest RBRemoveMethodParametrizedTest RBRemoveParameterParametrizedTest RBRemoveSenderMethodParametrizedTest RBRenameClassVariableParametrizedTest RBRenameInstanceVariableParametrizedTest RBRenameMethodParametrizedTest RBRenamePackageParametrizedTest RBRenameTemporaryParametrizedTest RBRenameVariableParametrizedTest RBReplaceMessageSendParametrizedTest RBSplitCascadeParametrizedTest RBSplitClassParametrizedTest RBTemporaryToInstanceVariableParametrizedTest RBWithDifferentConstructorsParametrizedTest RBWithDifferentsArgumentsParametrizedTest RSMarkerDecorationParametrizedTestProposal I know the effort is better spent on something else, but this bothers me as much as reading text with spelling errors. The affected classes should be renamed. The 4 SUnit classes should also have a deprecated alias to avoid breaking users.