search

pharo-project / pharo

Pharo is a dynamic reflective pure object-oriented language supporting live programming inspired by Smalltalk.
http://pharo.org
Other
1.21k stars 356 forks source link

Fix test suite to show progress bar running tests #17355

Open bouraqadi opened 1 week ago

request-info[bot] commented 1 week ago

This issue has either a default title or empty body. We would appreciate it if you could provide more information. Note: I am not a very intelligent bot, I can only react to new comments. Please add a comment for me if you update the body or title.

bouraqadi commented 1 week ago

The code is straightforward

TestSuite >> #runWith: aBlock
    self setUp.
    [
    self shuffledTests 
        do: [ :each |
            aBlock value: each.
            self announceTest: each.
            self changed: each ] 
        displayingProgress: [: currentTest | currentTest className] 
    ] ensure: [ self tearDown ]
Ducasse commented 1 week ago

Noury I was wondering if we should not do something else: introduce a runWithProgress: because with your changes any runWith: is impacted.

bouraqadi commented 1 week ago

Stef. Not sure to understand. The runWith: method is only implemented by TestSuite, and was already there. It was already opening the progress bar, but not show the progress. The change impacts only TestSuite>>#run: and TestSuite>>#debug

On Nov 9 2024, at 10:20 pm, StéphaneDucasse @.***> wrote:

Noury I was wondering if we should not do something else: introduce a runWithProgress: because with your changes any runWith: is impacted. — Reply to this email directly, view it on GitHub (https://github.com/pharo-project/pharo/pull/17355#issuecomment-2466463252), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AADKJD3KJOYH4XZWJFH2XFTZ7Z4DFAVCNFSM6AAAAABRPGMYA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRWGQ3DGMRVGI). You are receiving this because you authored the thread.