search

pharo-project / pharo

Pharo is a dynamic reflective pure object-oriented language supporting live programming inspired by Smalltalk.
http://pharo.org
Other
1.21k stars 356 forks source link

String concatenation rule could be raised when we have more than one #, #17364

Open Ducasse opened 1 week ago

Ducasse commented 1 week ago

This way is would make more sense.

MarcusDenker commented 1 week ago

This rule is I think an example of a rule that we should not check statically, but dynamically... concatenation is only bad of it happens a lot, and that we (in the end) cannot detect statically.

It would be interesting to think about other "rules" of the same direction, e.g. we were discussion usage of private methods. Trivially detectable on an anntoated test run. There are for sure more!

Rinzwind commented 6 days ago

There’s an earlier issue that seems relevant here: issue #2794, titled “String concatenation critique is too strict”.