search

pharo-project / pharo

Pharo is a dynamic reflective pure object-oriented language supporting live programming inspired by Smalltalk.
http://pharo.org
Other
1.21k stars 356 forks source link

Backport addition of discardBuffer to ZnBufferedReadStream>>#readInto:startingAt:count in the case that the buffer is bypassed to Pharo 11 #17382

Open Rinzwind opened 6 days ago

Rinzwind commented 6 days ago

This pull request backports the changes of pull request #17055 to Pharo 11.

Note that the most recent build (730), as well as the three previous ones (727–729), of the Jenkins ‘Pharo11’ job failed at the ‘Full Image-64’ stage.

Rinzwind commented 5 days ago

About the failing ‘Pharo11’ builds: build 730 had a ‘Segmentation fault’ at line 854 in the ‘Full Image-64‘ stage output, while the error in build 729 at line 883 in the ‘Full Image-64’ stage output seems to be due to BaselineOfNewToolsDocumentBrowser referring to an nonexistent branch ‘integration’ in the ‘Microdown’ repository, builds 728 and 727 had a similar error. Because of these failures, the most recent available Pharo 11 image does not include the changes of pull requests #16485 and #17131.

Ducasse commented 4 days ago

Thanks Kris. I do not really know why P11 is breaking I did not change (or may be it was not expected) branch in microdown.

Ducasse commented 4 days ago

I will ask the experts around me to see what we can do. @tesonep?

Rinzwind commented 3 days ago

Well, I guess you just don’t remember deleting it as ‘Branch deletions’ in the repository’s ‘Activity’ shows that was already several months ago, on March 13th, along with a bunch of other branches. The ‘Compare changes’ option (screenshot below) points to commit c6ed4ba, same as on the screenshot in issue #17391.

jecisc commented 3 days ago

In addition to microdown we also need to update the file server infos to use the new one if we want to publish new P11 images