pharo-project / pharo

Pharo is a dynamic reflective pure object-oriented language supporting live programming inspired by Smalltalk.
http://pharo.org
Other
1.21k stars 356 forks source link

DebugPointInstanceVariableTarget should not blindly use a global variable #17396

Open Ducasse opened 2 hours ago

Ducasse commented 2 hours ago
DebugPointInstanceVariableTarget >> browse

    (Smalltalk tools browser openOnClass:
             self instanceVariable owningClass)
        switchToVariables;
        selectVariableNamed: self instanceVariable name

=>

DebugPointInstanceVariableTarget >> browse

    (application tools browser openOnClass:
             self instanceVariable owningClass)
        switchToVariables;
        selectVariableNamed: self instanceVariable name
Ducasse commented 2 hours ago

A debug point should be configured from the tools and get passed the information of the object responsible to open a UI e.g. from a presenter we should pass its application!

Let us stop to be collectively abused by global variables. Smalltalk tools will be killed in Pharo 13 so be prepared.

Ducasse commented 1 hour ago

http://rmod-pharo-mooc.lille.inria.fr/AdvancedDesignMooc/Slides/M9-4-CaseStudy-06-LayeredSettingsArchitecture.pdf