search

pharo-project / pharo

Pharo is a dynamic reflective pure object-oriented language supporting live programming inspired by Smalltalk.
http://pharo.org
Other
1.21k stars 356 forks source link

Tag some ExternalAddress method as to ignore by testNoEquivalentSuperclassMethods #17416

Open jecisc opened 2 days ago

jecisc commented 2 days ago

ExternalAddress reimplement multiple methods from it superclass to do the same and have some speed ups. Here I'm adding a pragma so that we declare them as false positive in testNoEquivalentSuperclassMethods with the goal of reducing little by little the number of violations of this test

Ducasse commented 14 hours ago

Good we should call that monomorphising the call sites :)

Ducasse commented 14 hours ago

ReleaseTest.testNoEquivalentSuperclassMethods

Ducasse commented 3 hours ago

Build did not pass and I wonder if this is not one of integration of hernan PR I did yesterday. This UI is super confusing.