pharo-project / pharo

Pharo is a dynamic reflective pure object-oriented language supporting live programming inspired by Smalltalk.
http://pharo.org
Other
1.21k stars 356 forks source link

Can't format code in the debugger #2569

Closed macta closed 3 years ago

macta commented 5 years ago

We talk a lot about coding in the debugger (which is fab) - but why can't we reformat the code in the debugger? The menu item is mising.

stale[bot] commented 5 years ago

To limit bug bankruptcy (see https://www.joelonsoftware.com/2012/07/09/software-inventory/) this issue has been automatically marked as stale because it has not had any activity in 6 months. It will be closed in 1 month if no further activity occurs. If this issue remains important to you, please comment to reactivate the issue. Thank you for your contributions.

Joel on Software
Software Inventory
Imagine, for a moment, that you came upon a bread factory for the first time. At first it just looks like a jumble of incomprehensible machinery with a few people buzzing around. As your eyes adjus…
macta commented 5 years ago

This is still relevant in Pharo 8, however, I notice there is a workaround - it appears that in the debugger, CMD-T (suggest) doesn't always give the full menu like in the regular editor (which has Format Code as the list item) - instead it gives much more context sensitive info. However, if you select all the code and CMD-T - format is available (and it is also available if you happen to go to the top of the code as well). The trouble is - not many would know this, and often you have fixed a bug in the middle of of your code and then the format menu item, or suggest menu item - just don't appear.

guillep commented 4 years ago

Hi @macta

The CMD+T is the suggestions menu. It does not show the entire set of options (like copy/paste too). It only shows options related to the place where the caret is (like, the variable or call-site).

It also seems the main menu is not showing the formatting entry.

Does the shortcut CMD+SHIFT+F do the reformat for you?

I'd like to summarize:

So we should add the "format method" menu entry in the main menu, is that it? Maybe I misunderstood

macta commented 4 years ago

Hi Guile - there are 2 things wrong in current P8, CMD-T doesn’t work in the debugger (the shortcut isn’t enabled).

If you right click and get the context menu - there is no “source code” sub menu (which cmd-t should trigger) and then in that menu is format .

See photo - where I have added some code in the debugger and wanted to format it (in fact - as we always claim that we code in the debugger, the debugger code pane should operate the same way as the code pain in the system browser). image

On 27 Mar 2020, at 10:57, Guille Polito notifications@github.com wrote:

Hi @macta https://github.com/macta The CMD+T is the suggestions menu. It does not show the entire set of options (like copy/paste too). It only shows options related to the place where the caret is (like, the variable or call-site).

It also seems the main menu is not showing the formatting entry.

Does the shortcut CMD+SHIFT+F do the reformat for you?

I'd like to summarize:

the "format method" option is not in the (debugger) menu entry but it is available in the suggestions for the entire method we can format using the shortcut So we should add the "format method" menu entry in the main menu, is that it? Maybe I misunderstood

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pharo-project/pharo/issues/2569#issuecomment-604938139, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKL3V3UM65IAOGFHHXQT4LRJSBCFANCNFSM4GXYE4AQ.

StevenCostiou commented 3 years ago

This is now possible in Pharo 9 with the new debugger. I propose to close this issue.