methods and protocols selection needs confusing extra clicks

[pavel-krivanek]

in Calypso, if you have selected method or protocol, the next click that changes focus to this list removes the selection. That causes the need for extra clicks:

1) you have a selected protocol and a selected method with a focus on the methods pane 2) the next click on the protocol deselects it, a message template for a new method without assigned protocol is displayed 3) click on a protocol selects it, the message template for a method in this protocol is displayed 4) you click on a method name, the method is not correctly displayed because it was in fact deselected so a message template for a method without assigned protocol is displayed 5) the second click on the method selects it

[bencoman]

I second that motion :)
I got used to it but its still annoying.

[dionisiydk]

I think I agree with you. I did not feel in used to it after long time. When you deselect protocol the tab with method is still here but not selected. And to select it again the habit wants to select the method instead of tab and here the workflow breaks.

The story about this feature is to have similar behaviour as with single pane (no tabs) browser and in same time keep "restore selection" behaviour. So in old browsers deselecting protocol gives you "new unclassified method pane" and resets existing method selection. In Calypso when you deselect the protocol the method pane is updated and previous selection is restored. It is general logic to restore selection anytime when content of pane is updated. Specifically it allows to switch between classes and see same selected method where it exists (try with #initialize method for example). So when discussed feature was not implemented this behaviour did not allow to create new unclassified method in this scenario because when method is selected the method tab become active. There were complains about it.

So the question is how to improve it. I think "restore selection" is useful and important feature and we would like to keep it. But managing it in various scenarios is not really easy.

[pavel-krivanek]

Maybe it is more Morphic/FastTable related issue. The first click on the selected item going from another focus should be ignored.

[dionisiydk]

ср, 15 мая 2019 г., 9:46 Pavel Krivanek notifications@github.com:

Maybe it is more Morphic/FastTable related issue. The first click on the selected item going from another focus should be ignored.

It will not fix your scenario. If selection will not change then tabs selection will not change either. And method tab will be not shown.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pharo-project/pharo/issues/3345?email_source=notifications&email_token=AB6FVID2JAAMVEE6N6ZSUMDPVPEWDA5CNFSM4HMWYPZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVN7B5A#issuecomment-492564724, or mute the thread https://github.com/notifications/unsubscribe-auth/AB6FVIBTXA6HPJH7UDQP7FLPVPEWDANCNFSM4HMWYPZQ .

[stale[bot]]

To limit bug bankruptcy (see https://www.joelonsoftware.com/2012/07/09/software-inventory/) this issue has been automatically marked as stale because it has not had any activity in 6 months. If no further activity occurs, it might be closed. If this issue remains important to you, please comment to reactivate the issue. Thank you for your contributions.

Joel on Software

Software Inventory

Imagine, for a moment, that you came upon a bread factory for the first time. At first it just looks like a jumble of incomprehensible machinery with a few people buzzing around. As your eyes adjus…