Pharo 8 DropListMorph ghostText: causes DNU in RubTextFieldArea

pharo-project / pharo

Pharo is a dynamic reflective pure object-oriented language supporting live programming inspired by Smalltalk.

http://pharo.org

Other

1.21k stars 355 forks source link

Closed riverdusty closed 2 years ago

riverdusty commented 4 years ago

simple example to cause issue. Pharo 8 64bit on Windows 10 64bit.

| aList |
aList := DropListMorph 
    on: nil list: (OrderedCollection new) 
    selected: nil
    changeSelected: nil.
aList ghostText: 'Select'

astares commented 4 years ago

ghostText: is deprecated anyway if you check all implementors
can confirm the error - we should deprecate the ghostText: from DropListMorph too (Pharo UI building is moving towards Spec2 anyway and there the method is called #placeholder:)

riverdusty commented 4 years ago

Would also help to write a test for this (substituting ghostText for placeholder) so this doesn't reoccur in the future

Ducasse commented 4 years ago

Thanks please send a test.

riverdusty commented 4 years ago

Thanks please send a test.

Is this the new way of saying,"Submit a diff" ? xD

I will do a PR with a test when i get a chance

MarcusDenker commented 2 years ago

Can you check if this is still needed?