search

pharo-project / pharo

Pharo is a dynamic reflective pure object-oriented language supporting live programming inspired by Smalltalk.
http://pharo.org
Other
1.21k stars 356 forks source link

ThemeIcons class side deserves some cleaning #6389

Closed Ducasse closed 2 months ago

Ducasse commented 4 years ago

Smalltalk ui theme and UIManager default should be factored out.

Ducasse commented 4 years ago

I would be probably good to have a separate class for the class side method and call it IconLoader and ThemeIcons (could be renamed IconPac)

Ducasse commented 12 months ago 
uiFetchPacks
    | choosenPacks remotePacks |

    UIManager default
        informUser: 'Retrieving available packs from remote repository'
        during: [ remotePacks := self fetchPacks ].

    choosenPacks := (TickDialogWindow
        itemsList: remotePacks
        itemsHeaderName: nil
        wrapBlockOrSelector: #name
        title: 'Remote available icon packs')
        chooseFromOwner: self currentWorld.
    choosenPacks ifNil: [ ^ self ].
    UIManager default informUserDuring: [ :bar |
        choosenPacks do: [ :each |
            bar label: 'Retrieving "', each name, '" icon set from remote repository'.
            each downloadFromUrl ]]
Ducasse commented 12 months ago

So either we have a little presenter for this or we just remove it!