search

pharo-project / pharo

Pharo is a dynamic reflective pure object-oriented language supporting live programming inspired by Smalltalk.
http://pharo.org
Other
1.21k stars 355 forks source link

Dead outdated code of dependencies are in the Pharo repo #9822

Closed dionisiydk closed 1 year ago

dionisiydk commented 3 years ago

Check the Sindarin packages. They still present in Pharo repo but they are downloaded at every built. Probably there are other garbage.

It's really important to sort it. Because it is super confusing. Any code changes in such bad dependencies are shown in the Iceberg as Pharo changes. Then you don't notice it and get super "fun" time trying to understand why the final image does not include your code (while it is shown as normal changes in diff).

astares commented 3 years ago

@dionisiydk I'm not sure I understand what you mean here. The Sindarin packages are in the sources of Pharo 10 branch: https://github.com/pharo-project/pharo/tree/Pharo10/src

image

as well as in the image:

image

are they not used?

GitHub
pharo/src at Pharo10 · pharo-project/pharo
Pharo is a dynamic reflective pure object-oriented language supporting live programming inspired by Smalltalk. - pharo/src at Pharo10 · pharo-project/pharo
dionisiydk commented 3 years ago

Yes. That's the problem. Sindarin is always loaded and it overrides the code in this repo. See BaselineOfNewTools>>#sindarin: and users.

astares commented 3 years ago

Ah - OK. So it is managed "externally" (loaded from another repo) and "internally" (pharo repo)

MarcusDenker commented 1 year ago

added a newer entry: https://github.com/pharo-project/pharo/issues/13966