Set up branch protection to forbid direct modification of master branch

pharo-rdbms / Pharo-SQLite3

Community-owned official SQLite3 binding for Pharo

MIT License

22 stars 20 forks source link

Set up branch protection to forbid direct modification of master branch #11

Closed juliendelplanque closed 2 years ago

juliendelplanque commented 4 years ago

Like that we can make sure any change is reviewed before integration.

astares commented 4 years ago

A branch protection only means we need to have PR's - but an integrator can then still:

do a PR
merge it directly into the branch

No?

juliendelplanque commented 4 years ago

For sure, but then it just means that we trust integrators... Which should be the case else, the integrator should not be.

What do you think?

astares commented 4 years ago

Let's ask @PierceNg

PierceNg commented 4 years ago

On Wed, Dec 11, 2019 at 01:59:42AM -0800, Astares wrote:

Let's ask @PierceNg

I don't know what these phrases mean. Please define:

branch protection of master
direct modification

Edit: Ignore this comment. I replied to email and didn't see existing comments until now.

PierceNg commented 4 years ago

I don't know GH beyond the basics. Here integrator refers to those with write access to this repo, and currently that means all 7 members of team pharo-rdbms?

gcotelli commented 4 years ago

The branch protection can be configured in two modes:

One does not allow to merge a PR if the CI is not passing and a configurable number of reviewers approves it, or push directly to the protected branch. Even for administrators.
The other mode allows that a repo admin merge a PR even if the other conditions are not met. However the UI will warn of that. And it allows direct push to the protected branch from the repo admins. And this is pretty configurable, so you can select what CI tasks are required or if you want reviewers approval or not.