When Glorp is not using bindings (for example on delete:where:) it later expects that the driver responds the rowCount in some cases. I'm doing here something similar to what P3 driver does.
Once this got merged, pharo-rdbms/glorp#28 can be merged. It adds a test that exposes the error fixed in this PR.
AFAIK when basicExecuteSQLString:binding: is used directly the driver don't need to keep the rowCount because it is asked to the result (that is some kind of Cursor), so I'm keeping track of that only when the bindings are not in use.
tblanchard
commented
4 years ago
When Glorp is not using bindings (for example on
delete:where:) it later expects that the driver responds therowCountin some cases. I'm doing here something similar to what P3 driver does.Once this got merged, pharo-rdbms/glorp#28 can be merged. It adds a test that exposes the error fixed in this PR.
AFAIK when
basicExecuteSQLString:binding:is used directly the driver don't need to keep the rowCount because it is asked to the result (that is some kind of Cursor), so I'm keeping track of that only when the bindings are not in use.