Fix reading of Time instances from the database

pharo-rdbms / Pharo-SQLite3

Community-owned official SQLite3 binding for Pharo

MIT License

22 stars 20 forks source link

Fix reading of Time instances from the database #35

Closed gcotelli closed 3 years ago

gcotelli commented 3 years ago

These changes fix two Glorp integration tests (GlorpTimeTest and GlorpTimeWithTimeZoneTest). Time instances are saved in the database as DateTime (check #isDateAndTimeLike:) so when we are reading it back Time fromString: don't parse it correctly.

gcotelli commented 3 years ago

Fixes #30

gcotelli commented 3 years ago

I've updated the implementation to not save instances of Time and Date as DateAsTime. However this breaks backwards compatibility with existing databases at least for date fields (because the Time ones were not working)