pharo-rdbms / Pharo-SQLite3

Community-owned official SQLite3 binding for Pharo
MIT License
22 stars 20 forks source link

Change parameter type from `ExternalAddress` to `void *` #39

Closed akgrant43 closed 3 years ago

akgrant43 commented 3 years ago

in:

With the move to TFFI in Pharo 9 using ExternalAddress sometimes triggers an 'object is not pinned' error.

This change is backward compatible with Pharo 8 (the automated tests still pass).

codecov[bot] commented 3 years ago

Codecov Report

Merging #39 (4e00006) into master (7614fe8) will decrease coverage by 0.88%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage   77.63%   76.75%   -0.89%     
==========================================
  Files         101      100       -1     
  Lines        4086     4013      -73     
==========================================
- Hits         3172     3080      -92     
- Misses        914      933      +19     
Impacted Files Coverage Δ
...QLite3-Core/SQLite3DatabaseExternalObject.class.st 100.00% <100.00%> (ø)
...Lite3-Core/SQLite3StatementExternalObject.class.st 57.14% <100.00%> (ø)
src/SQLite3-Core/SQLite3Row.class.st 59.13% <0.00%> (-6.46%) :arrow_down:
src/SQLite3-Core/SQLite3BaseConnection.class.st 91.39% <0.00%> (-3.28%) :arrow_down:
src/SQLite3-Core/SQLite3Library.class.st 64.80% <0.00%> (-0.74%) :arrow_down:
src/SQLite3-Glorp/SQLite3Driver.class.st

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7614fe8...4e00006. Read the comment docs.

astares commented 3 years ago

I guess PR #39 and PR #40 have been summarized into PR #41.

It was just mentioned on Discord. Lets close #39 and #40 to avoid confusion.

image