search

pharo-rdbms / Pharo-SQLite3

Community-owned official SQLite3 binding for Pharo
MIT License
22 stars 20 forks source link

Pharo 9 TFFI assumes functions with String return type are UTF8 and decodes #40

Closed akgrant43 closed 3 years ago

akgrant43 commented 3 years ago

Modify SQLite3Library>>utf8StringToPharo: to not decode the UTF8 in Pharo 9 and later.

codecov[bot] commented 3 years ago

Codecov Report

Merging #40 (b70179d) into master (7614fe8) will decrease coverage by 0.86%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   77.63%   76.76%   -0.87%     
==========================================
  Files         101      100       -1     
  Lines        4086     4015      -71     
==========================================
- Hits         3172     3082      -90     
- Misses        914      933      +19
Impacted Files Coverage Δ
src/SQLite3-Core/SQLite3Library.class.st 64.90% <100.00%> (-0.64%) :arrow_down:
src/SQLite3-Core/SQLite3Row.class.st 59.13% <0.00%> (-6.46%) :arrow_down:
src/SQLite3-Core/SQLite3BaseConnection.class.st 91.39% <0.00%> (-3.28%) :arrow_down:
src/SQLite3-Glorp/SQLite3Driver.class.st

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7614fe8...b70179d. Read the comment docs.

gcotelli commented 3 years ago

This PR looks like is included in #41 or Am I missing something?

astares commented 3 years ago

I guess PR #39 and PR #40 have been summarized into PR #41.

It was just mentioned on Discord. Lets close #39 and #40 to avoid confusion.

image