search

pharo-rdbms / Pharo-SQLite3

Community-owned official SQLite3 binding for Pharo
MIT License
22 stars 20 forks source link

Add support P11, P12 and fix #60 #61

Closed astares closed 1 year ago

astares commented 1 year ago

fix #60

codecov[bot] commented 1 year ago

Codecov Report

Merging #61 (d31ab49) into master (0fe7fe6) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   78.71%   78.71%           
=======================================
  Files         107      107           
  Lines        4444     4444           
=======================================
  Hits         3498     3498           
  Misses        946      946

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

astares commented 1 year ago

Mmmhhh .... strange: CI throws an primitive error in Threaded FFI (TFFI) Backend

image image

@tesonep can you help

astares commented 1 year ago

To reproduce load Glorp into latest Pharo 12 on Windows and run #testTime

gcotelli commented 1 year ago

I'm researching this a bit and seems that the data written in the DB is not right for datetime and time columns. So maybe the problem is in the storing function calls and not in the retrieval ones.

gcotelli commented 1 year ago

I've found the problem. The methods putting dates, date times, and times are not encoding the string representations as UTF8. I don't know why it worked previously, maybe some FFI changes broke it?