search

pharo-rdbms / Pharo-SQLite3

Community-owned official SQLite3 binding for Pharo
MIT License
22 stars 20 forks source link

Do not set the underlying SQLite3 library handle to NULL when closing the connection #67

Closed gcorriga closed 1 year ago

gcorriga commented 1 year ago

Do not set the underlying SQLite3 library handle to NULL when closing the connection.

Doing so has the side effect of turning sqlite3_close_v2() into a no-op when invoked from SQLite3DatabaseExternalObject>>doFinalizeResourceData:

codecov[bot] commented 1 year ago

Codecov Report

Merging #67 (0516cc7) into master (b50573a) will increase coverage by 0.05%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
+ Coverage   78.67%   78.73%   +0.05%     
==========================================
  Files         108      108              
  Lines        4423     4454      +31     
==========================================
+ Hits         3480     3507      +27     
- Misses        943      947       +4
Impacted Files Coverage Δ
...ite3-Core-Tests/SQLite3BaseConnectionTest.class.st 91.34% <100.00%> (+0.38%) :arrow_up:
src/SQLite3-Core/SQLite3BaseConnection.class.st 93.43% <100.00%> (ø)

... and 1 file with indirect coverage changes

gcotelli commented 1 year ago

BTW, the coverage is decreasing because now SQLite3DatabaseExternalObject >> beNull is not sent in any tests. We can check the senders and if not used anymore remove it.