search

pharo-rdbms / Pharo-SQLite3

Community-owned official SQLite3 binding for Pharo
MIT License
22 stars 20 forks source link

use execute onlyValue in SQLite3Table>>#numberOfRows #70

Closed vonbecmann closed 1 year ago

vonbecmann commented 1 year ago

use execute onlyValue in SQLite3Table>>#numberOfRows. and add some tests. fix: #69

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.29% :tada:

Comparison is base (f85b936) 78.73% compared to head (0baf880) 79.02%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #70 +/- ## ========================================== + Coverage 78.73% 79.02% +0.29% ========================================== Files 108 108 Lines 4454 4473 +19 ========================================== + Hits 3507 3535 +28 + Misses 947 938 -9 ``` | [Files Changed](https://app.codecov.io/gh/pharo-rdbms/Pharo-SQLite3/pull/70?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pharo-rdbms) | Coverage Δ | | |---|---|---| | [src/SQLite3-Core-Tests/SQLite3TableTest.class.st](https://app.codecov.io/gh/pharo-rdbms/Pharo-SQLite3/pull/70?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pharo-rdbms#diff-c3JjL1NRTGl0ZTMtQ29yZS1UZXN0cy9TUUxpdGUzVGFibGVUZXN0LmNsYXNzLnN0) | `100.00% <100.00%> (ø)` | | | [src/SQLite3-Core/SQLite3Database.class.st](https://app.codecov.io/gh/pharo-rdbms/Pharo-SQLite3/pull/70?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pharo-rdbms#diff-c3JjL1NRTGl0ZTMtQ29yZS9TUUxpdGUzRGF0YWJhc2UuY2xhc3Muc3Q=) | `68.75% <100.00%> (+1.64%)` | :arrow_up: | | [src/SQLite3-Core/SQLite3Table.class.st](https://app.codecov.io/gh/pharo-rdbms/Pharo-SQLite3/pull/70?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pharo-rdbms#diff-c3JjL1NRTGl0ZTMtQ29yZS9TUUxpdGUzVGFibGUuY2xhc3Muc3Q=) | `87.09% <100.00%> (+9.31%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/pharo-rdbms/Pharo-SQLite3/pull/70/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pharo-rdbms)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.