search

pharo-rdbms / glorp

Generic Lightweight Object Relational Persistence
MIT License
23 stars 24 forks source link

Unreferenced global in DB2Sequence>>#name: #140

Open astares opened 1 year ago

astares commented 1 year ago

image

astares commented 1 year ago

This is a bug for DB2 support only then (which is incomplete anyway) We should refactor specific DB support in separate loadable packages

JoachimTuchel commented 1 year ago

While I agree on the separate loadable packages, I want to add a comment on the method's way of operation in general (completely unrelated, btw): I don't think it is good practice to truncate the name of a table or sequence, even if the limit is ridiculously high (128 in case of DB2). I'd rather be notified by an exception that I am doing something wrong here. But as I said, unrelated to the issue at hand.

JoachimTuchel commented 1 year ago

... and I don't like the fact that such a constant value is retrieved from an instance method. Is it really necessary to create an instance of the DB2Platform just to ask it for a number that is a global value (=class side)?