search

pharo-rdbms / glorp

Generic Lightweight Object Relational Persistence
MIT License
24 stars 24 forks source link

Update GlorpSQLite3 README.md link #152

Closed labordep closed 10 months ago

labordep commented 10 months ago

The link to SQLite3 in the readme redirects to a SQLite3 library that does not utilize Glorp. I believe the correct link is: https://github.com/PierceNg/glorp-sqlite3.

gcotelli commented 10 months ago

The link is OK as it is. The referenced project includes an optional group with the Glorp-related code. It's also continuously tested See https://github.com/pharo-rdbms/glorp/blob/master/.smalltalkci/.SQLite3.ston

labordep commented 10 months ago

Ok thanks. I realize that something is missing in the project documentation.

The readme said "Use its Metacello snippet to load both Glorp and the driver in one go" and when I am on the page there is no script to "load both Glorp and the driver in one go" and no mention to Glorp! It's not clear that we need to load a thing that isn't obvious to guess.

gcotelli commented 10 months ago

Please propose an update to the readme so it's more clear. The docs in the project are in need of some love.

On Sat, Jan 20, 2024, 09:57 Pierre Laborde @.***> wrote:

Ok thanks. I realize that something is missing in the project documentation.

The readme said "Use its Metacello snippet to load both Glorp and the driver in one go" and when I am on the page there is no script to "load both Glorp and the driver in one go" and no mention to Glorp! It's not clear that we need to load a thing that isn't obvious to guess.

— Reply to this email directly, view it on GitHub https://github.com/pharo-rdbms/glorp/pull/152#issuecomment-1902087687, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQCK6ES6XBEE5WV7M32TDDYPO5MJAVCNFSM6AAAAABCDEQW3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSGA4DONRYG4 . You are receiving this because you modified the open/close state.Message ID: @.***>

labordep commented 10 months ago

Please propose an update to the readme so it's more clear. The docs in the project are in need of some love. … On Sat, Jan 20, 2024, 09:57 Pierre Laborde @.> wrote: Ok thanks. I realize that something is missing in the project documentation. The readme said "Use its Metacello snippet to load both Glorp and the driver in one go" and when I am on the page there is no script to "load both Glorp and the driver in one go" and no mention to Glorp! It's not clear that we need to load a thing that isn't obvious to guess. — Reply to this email directly, view it on GitHub <#152 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQCK6ES6XBEE5WV7M32TDDYPO5MJAVCNFSM6AAAAABCDEQW3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSGA4DONRYG4 . You are receiving this because you modified the open/close state.Message ID: @.>

You have right :) I will propose an update if I succeed to load the sub-project with glorp >< see: https://github.com/pharo-rdbms/Pharo-SQLite3/issues/108

gcotelli commented 10 months ago

I don't have access to the computer until the next month. But doing something like this should work:

Metacello new repository: 'github://pharo-rdbms/Pharo-SQLite3/src'; baseline: 'SQLite3'; load:#('Core' 'glorp')

There's no need to manually load the dependencies. And if you want to load it by hand you need to use the same version declared as dependency in the Baseline.

On Sat, Jan 20, 2024, 10:39 Pierre Laborde @.***> wrote:

Please propose an update to the readme so it's more clear. The docs in the project are in need of some love. … <#m-5032872237467112048> On Sat, Jan 20, 2024, 09:57 Pierre Laborde @.> wrote: Ok thanks. I realize that something is missing in the project documentation. The readme said "Use its Metacello snippet to load both Glorp and the driver in one go" and when I am on the page there is no script to "load both Glorp and the driver in one go" and no mention to Glorp! It's not clear that we need to load a thing that isn't obvious to guess. — Reply to this email directly, view it on GitHub <#152 (comment) https://github.com/pharo-rdbms/glorp/pull/152#issuecomment-1902087687>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQCK6ES6XBEE5WV7M32TDDYPO5MJAVCNFSM6AAAAABCDEQW3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSGA4DONRYG4 https://github.com/notifications/unsubscribe-auth/AAQCK6ES6XBEE5WV7M32TDDYPO5MJAVCNFSM6AAAAABCDEQW3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSGA4DONRYG4 . You are receiving this because you modified the open/close state.Message ID: @.>

You have right :) I will propose an update if I succeed to load the sub-project with glorp

< see: pharo-rdbms/Pharo-SQLite3#108 https://github.com/pharo-rdbms/Pharo-SQLite3/issues/108

— Reply to this email directly, view it on GitHub https://github.com/pharo-rdbms/glorp/pull/152#issuecomment-1902096363, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQCK6AC4OXNIUHR24437XTYPPCILAVCNFSM6AAAAABCDEQW3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSGA4TMMZWGM . You are receiving this because you modified the open/close state.Message ID: @.***>

labordep commented 10 months ago

Thanks I will complete my issue with this dicussion :)