pharo-spec / NewTools

All development tools for Pharo, developed with Spec
21 stars 53 forks source link

Removing dependency to UIManager in StDebugger #744

Closed adri09070 closed 3 months ago

adri09070 commented 5 months ago

Fixes https://github.com/pharo-project/pharo/issues/15430

Needs https://github.com/pharo-spec/Spec/pull/1540 to be merged first

Ducasse commented 5 months ago

Thanks adrian let us see what esteban will say. @estebanlm

estebanlm commented 5 months ago

yes, this is fine but let's wait until the CI is working again (when Pharo13 is added)

MarcusDenker commented 5 months ago

I added an issue to the main issue tracker for the CI:

https://github.com/pharo-project/pharo/issues/16589

jecisc commented 4 months ago

Test failure not related.

Ducasse commented 3 months ago

@adri09070 Can you have a look at the conflict? I'm taking the lead to merge or close all the pending PRs because I'm fed up of the message we send around.

adri09070 commented 3 months ago

This PR can simply be closed without merge. #760 completely removed the method that I changed and it's ok