Closed jecisc closed 3 months ago
I also added a bunch of tests
Failing tests are unrelated
But why merging with fuel? I do not get the idea.
It's to avoid to have a lot of packages with 1 class or 2 extension methods.
We had Compression-Utils with 2 extension methods and NewTools-Fuel with 2 extensions and 1 class. And here with the protocol chooser it would be yet another package with 1 class
Ok but to me the protocol chooser should be packaged with core functionality and zip and fuel not. If we start to group random things then we will get packages with strange dependencies. To me it is not awkward to have tiny packages. So I would package the chooser in a core package and not have a package for it.
I moved it
This change introduces a class StProtocolNameChooserPresenter.
This new interface in Spec allows one to select a protocol name to replace the UI in morphic. Features:
I also propose to merge NewTools-Fuel, NewTools-Compression-Utils and this new presenter in a package NewTools-Utils to avoid having a lot of packages with only one class or one extension method