pharo-spec / NewTools

All development tools for Pharo, developed with Spec
21 stars 52 forks source link

Revert "Use taskbar icon name for inspector and playground" #779

Closed Ducasse closed 1 month ago

Ducasse commented 1 month ago

Reverts pharo-spec/NewTools#771

I will revert this PR since it breaks Pharo

Form(Object)>>doesNotUnderstand: #asSymbol
ThemeIcons>>iconFormSetNamed:ifNone:
ThemeIcons>>iconFormSetNamed:
TaskbarItemMorph(Object)>>iconFormSetNamed:
TaskbarItemMorph>>initializeFor:
PharoLightTheme(UITheme)>>newTaskbarButtonIn:forTask:
TaskbarTask>>taskbarButtonFor:
[:t | | button |
        button := t taskbarButtonFor: self.
        button ifNotNil: [self addMorphBack: button]] in TaskbarMorph>>updateTaskButtons in Block: [:t | | button |...
OrderedCollection>>do:
TaskbarMorph>>updateTaskButtons
TaskbarMorph>>updateTasks
[self updateBounds.
    self updateTasks] in TaskbarMorph>>ownerChanged in Block: [self updateBounds....
FullBlockClosure(BlockClosure)>>on:do:
TaskbarMorph>>ownerChanged
[:m | m ownerChanged] in WorldMorph(Morph)>>doLayoutIn: in Block: [:m | m ownerChanged]
Array(SequenceableCollection)>>do:
WorldMorph(Morph)>>doLayoutIn:
WorldMorph(Morph)>>computeFullBounds
WorldMorph(Morph)>>fullBounds
MorphicEventDispatcher>>dispatchDefault:with:
MorphicEventDispatcher>>handleMouseMove:
MouseMoveEvent>>sentTo:
[ ^ anEvent sentTo: self ] in MorphicEventDispatcher>>dispatchEvent:with: in Block: [ ^ anEvent sentTo: self ]
FullBlockClosure(BlockClosure)>>ensure:
MorphicEventDispatcher>>dispatchEvent:with:
WorldMorph(Morph)>>processEvent:using:
WorldMorph(Morph)>>processEvent:
HandMorph>>sendEvent:focus:clear:
HandMorph>>sendMouseEvent:
HandMorph>>handleEvent:
[
        (morphicWorld activeHand isNotNil and: [ anEvent hand isNotNil ]) ifTrue: [
            morphicWorld activeHand handleEvent: anEvent
        ]
    ] in OSWindowMorphicEventHandler>>dispatchMorphicEvent: in Block: [...
WorldState>>runStepMethodsIn:
WorldMorph>>runStepMethods
WorldState>>doOneCycleFor:
WorldMorph>>doOneCycleNow
WorldMorph>>doOneCycle
[
        | extraWorldsToDraw |
        extraWorldsToDraw := ExtraWorldListMutex critical: [
                                 self extraWorldList ].
        extraWorldsToDraw do: [ :world | world doOneCycle ].

        (self currentWorld isNotNil and: [
             (extraWorldsToDraw includes: self currentWorld) not ]) ifTrue: [
            self currentWorld doOneCycle ] ] in WorldMorph class>>doOneCycle in Block: [...
FullBlockClosure(BlockClosure)>>ensure:
WorldState class>>doDrawCycleWith:
WorldMorph class>>doOneCycle
MorphicRenderLoop>>doOneCycle
MorphicRenderLoop>>doOneCycleWhile:
[ MorphicRenderLoop new doOneCycleWhile: [ true ] ] in MorphicUIManager>>spawnNewProcess in Block: [ MorphicRenderLoop new doOneCycleWhile: [ tru[..]
[self value.
            "IMPORTANT: Do not step over next line of code. See method comments for details"
            Processor terminateRealActive] in FullBlockClosure(BlockClosure)>>newProcess in Block: [self value....
badetitou commented 1 month ago

Hello

I suppose there was an not tested case. Can you explain how I can reproduce the bugs you had? So I'll try to understand and fix and add tests

Ducasse commented 1 month ago

Just loading the PR and trying to open iceberg