latest changes

[Ducasse]

@estebanlm the tests are green on ubuntu so can we integrate it?

[Ducasse]

ReleaseTest
 ✗ #testUndeclared (132ms)
 ✗ #testThatThereAreNoSelectorsRemainingThatAreSentButNotImplemented (573ms)

NoUnusedVariablesLeftTest
 ✗ #testNoUnusedInstanceVariablesLeft (7000ms)

[estebanlm]

yeah, let's go.

[jecisc]

This is breaking the Spotter and the Inspector

SpPresenterBuilder(Object)>>doesNotUnderstand: #application:
StInspectionContext>>newPresenterBuilder
StInspectionContext>>basicNewInspectionPresenter
OrderedCollection>>DoIt
OCReceiverDoItSemanticScope(OCDoItSemanticScope)>>evaluateDoIt:
OpalCompiler>>evaluate
[
        self announcer announce: (SpCodeWillBeEvaluatedAnnouncement newContent: aString).
        oldBindings := self interactionModel bindings copy.
        result := self interactionModel compiler
            source: aString;
            environment: self environment;
            failBlock:  [ 
                self announcer announce: (SpCodeEvaluationFailedAnnouncement newContent: aString).
                ^ compileErrorBlock value ];
            evaluate.
        oldBindings size = self interactionModel bindings size 
            ifFalse: [ self withAdapterDo: [ :anAdapter | anAdapter refreshStyling ] ].
        self announcer announce: (SpCodeEvaluationSucceedAnnouncement newContent: aString).
        result ] in SpCodePresenter>>evaluate:onCompileError:onError: in Block: [...
FullBlockClosure(BlockClosure)>>on:do:
SpCodePresenter>>evaluate:onCompileError:onError:
SpCodeDoItCommand(SpCodeSelectionCommand)>>evaluate:andDo:
SpCodeDoItCommand(SpCodeSelectionCommand)>>evaluateSelectionAndDo:
SpCodeDoItCommand>>execute
SpCommand(CmCommandDecorator)>>execute
[ self decoratedCommand execute ] in SpToolCurrentApplicationCommand>>execute in Block: [ self decoratedCommand execute ]
[ activeProcess
            psValueAt: index
            put: anObject.
        aBlock value ] in SpToolCurrentApplication(DynamicVariable)>>value:during: in Block: [ activeProcess...
FullBlockClosure(BlockClosure)>>ensure:
SpToolCurrentApplication(DynamicVariable)>>value:during:
SpToolCurrentApplication class(DynamicVariable class)>>value:during:
SpToolCurrentApplicationCommand>>execute
[ self decoratedCommand execute ] in SpToolCurrentApplicationCommand>>execute in Block: [ self decoratedCommand execute ]
[ activeProcess
            psValueAt: index
            put: anObject.
        aBlock value ] in SpToolCurrentApplication(DynamicVariable)>>value:during: in Block: [ activeProcess...
FullBlockClosure(BlockClosure)>>ensure:
SpToolCurrentApplication(DynamicVariable)>>value:during:
SpToolCurrentApplication class(DynamicVariable class)>>value:during:
SpToolCurrentApplicationCommand>>execute
[ 
            aCmCommand canBeExecuted 
                ifTrue: [ aCmCommand execute ] ] in SpKMCategoryBuilder>>visitCommand: in Block: [ ...
FullBlockClosure(BlockClosure)>>cull:
FullBlockClosure(BlockClosure)>>cull:cull:
FullBlockClosure(BlockClosure)>>cull:cull:cull:
KMCategoryBinding>>completeMatch:buffer:
[ :l | l completeMatch: self buffer: aBuffer ] in KMKeymap>>notifyCompleteMatchTo:buffer: in Block: [ :l | l completeMatch: self buffer: aBuffer ]
Array(SequenceableCollection)>>do:

[jecisc]

I'll revert it because it breaks P13 too much