search

pharo-spec / NewTools

All development tools for Pharo, developed with Spec
21 stars 54 forks source link

Correct evaluation of dynamic variables from the debugger #854

Closed StevenCostiou closed 3 weeks ago

StevenCostiou commented 1 month ago

Fixes https://github.com/pharo-project/pharo/issues/17038

StevenCostiou commented 1 month ago

hmm something is wrong in the tests

StevenCostiou commented 1 month ago

no idea why I have an error on newtools but not on pharo-integration...

StevenCostiou commented 1 month ago

So the code works in the debugger but the test is flaky. This is due to the means to build the test, it is not easy.

StevenCostiou commented 1 month ago

Trying to improve tests, but I think it is stiill flaky. I recommend merging the main commit but not the test, as at worst cases the behavior would be the same as before.

StevenCostiou commented 1 month ago

Ok it seems to pass now...

StevenCostiou commented 1 month ago

Ok the failing tests are because of the change. I will have to look for side effects.

StevenCostiou commented 4 weeks ago

I think the remaining failing test is not due to my changes (I can be wrong). I have not added code that would be identical to methods in super classes.

StevenCostiou commented 4 weeks ago

Ok this seems to be reproducible on the CI. Will check again, but in my image this release test does pass.

StevenCostiou commented 3 weeks ago

The failing tests are in new tools now, but concern the refactorings... I cannot udnerstand the relation.

And its working on Pharo...

StevenCostiou commented 3 weeks ago

We should merge @MarcusDenker