`testIsExecutionFinished` doesn't pass

adri09070 commented 2 years ago

The following test doesn't pass and it's the last one that needs to be corrected to finally have only green tests for Sindarin:

SindarinDebuggerTest>>#testIsExecutionFinished
    | scdbg |
    scdbg := SindarinDebugger debug: [ self helperMethod16 ].
    self deny: scdbg isExecutionFinished.
    scdbg
        stepOver;
        step;
        step;
        stepOver;
        step;
        stepOver;
        step.
    "Reached `self isActiveProcess` in Process>>#terminate"
    self assert: scdbg isExecutionFinished

This is because it does multiple steps when the debguged method contains only one message and a return so only 2 stepOver| should be performed:

helperMethod16

    ^ 1 + 1

We'll then see if the tested method works fine or not

adri09070 commented 2 years ago

Actually, I see that the related method has been fixed on Pharo side: https://github.com/pharo-project/pharo/pull/8567

These changes should have been integrated to this repo a year and a half ago. This important PR is also supposed to fix a crash caused by

SindarinDebugger>>#stepOver

adri09070 commented 2 years ago

Actually, these changes have been merged by https://github.com/pharo-spec/ScriptableDebugger/pull/14 into the Pharo10 branch.

Is there any reason why these changes haven't been merged into branch master?

pharo-spec / ScriptableDebugger

`testIsExecutionFinished` doesn't pass #25