pharo-spec / ScriptableDebugger

3 stars 12 forks source link

There are many duplicate helper methods in `SindarinDebuggerTest` with unexplicit names #29

Closed adri09070 closed 1 year ago

adri09070 commented 2 years ago

SindarinDebuggerTest has a lot of helperMethodXXX methods.

Actuallly, most of these methods have the same source code:

image

Out of the 29 helper methods from this class, 15 of them have the exact same source code. Only one from these 15 should be kept and the others should be deleted.

Plus, all these methods should have a more explicit name as, when I try to understand a test, it forces me to browse the helper method that is used in the test because it doesn't have an explicit name.