search

pharo-spec / Spec

Spec is a framework in Pharo for describing user interfaces.
MIT License
61 stars 63 forks source link

Added new subclass with unified view based on SpDiffPresenter #1452

Closed CarolinaMelendez closed 2 months ago

CarolinaMelendez commented 12 months ago

SpDiffPresenter displays a split view. So I added a sub-class that displays a unified view called SpDiffUnifiedPresenter

image

estebanlm commented 11 months ago

but this will not work. You need to include StUnifiedDiffChangesMorph in the correct place. (and call it SpUnifiedDiffChangesMorph) :P

Ducasse commented 11 months ago

BTW carolina talk to us if you want to do your bachelor with us at Lille. You can talk to seb.

CarolinaMelendez commented 11 months ago

Hi @estebanlm thanks for the review. I see I need to learn more. By the correct place of StUnifiedDiffChangesMorph you mean it should be in the same package together with DiffMorph ?

I would like to add that StUnifiedDiffChangesMorph is not a class I created, I just reuse that class because it already has the unified view there. I don't think I have the right to move the package. There is not a another way that make it works or is necessary to move the the location of StUnifiedDiffChangesMorph ?

jordanmontt commented 10 months ago

Hello, what is needed to accept this PR?

estebanlm commented 10 months ago

heh... nothing :) EDIT: I just saw there is a problem with dependencies.

Ducasse commented 2 months ago

IAfter 10 min I could not find a way to rerun this PR :( What a dead interface

Ducasse commented 2 months ago

So we will see if it breaks and in this case we will revert the PR