search

pharo-spec / Spec

Spec is a framework in Pharo for describing user interfaces.
MIT License
61 stars 63 forks source link

sync #1486

Closed estebanlm closed 9 months ago

Ducasse commented 10 months ago 
Instance of SHRBTextStyler did not understand #isScripting:
SpScrollableLayoutAdapterTest
 ✗ #testAddWithSymbolWorks (6ms)
 ✗ #testAddWithSymbolWorks (1ms)

SpListCommonPropertiestTest
 ✗ #testEnablingFilteringUpdateOpenedList (36ms)
 ✗ #testEnablingFilteringUpdateOpenedList (32ms)

SpCodeAdapterTest
 ✗ #testBeNotEditableAfterOpenWorks (26ms)
 ✗ #testBeNotEditableWorks (14ms)
 ✗ #testChangePlaceholderTextUpdatesPresenter (6ms)
 ✗ #testChangingHelpAffectTheWidget (4ms)
 ✗ #testEnabledAffectWidget (5ms)
 ✗ #testHidePresenterHidesWidget (4ms)
 ✗ #testKeyBindings (4ms)
 ✗ #testLineAtCursorPosition (6ms)
 ✗ #testPresenterPlaceholderIsSetInWidget (7ms)
 ✗ #testRightClickShowsMenu (4ms)
 ✗ #testSelectionInterval (32ms)
 ✗ #testSelectionIntervalNilUnselectsEverything (6ms)
 ✗ #testSettingTextManuallyAffectsTheUndoManager (4ms)
 ✗ #testSettingTextManuallyClearsTheUndoManager (4ms)
 ✗ #testShowPresenterShowsWidget (5ms)
 ✗ #testTextIsAlwaysString (5ms)
 ✗ #testTextWithStyle (21ms)
 ✗ #testVisibilityWithBlock (6ms)
 ✗ #testVisibilityWithBlockThatReturnsFalse (8ms)
 ✗ #testWithSyntaxHighlight (6ms)
 ✗ #testWithoutUndoRedoHistory (12ms)
 ✗ #testBeNotEditableAfterOpenWorks (12ms)
 ✗ #testBeNotEditableWorks (5ms)
 ✗ #testChangePlaceholderTextUpdatesPresenter (5ms)
 ✗ #testChangingHelpAffectTheWidget (4ms)
 ✗ #testEnabledAffectWidget (4ms)
 ✗ #testHidePresenterHidesWidget (5ms)
 ✗ #testKeyBindings (3ms)
 ✗ #testLineAtCursorPosition (3ms)
 ✗ #testPresenterPlaceholderIsSetInWidget (4ms)
 ✗ #testRightClickShowsMenu (3ms)
 ✗ #testSelectionInterval (5ms)
 ✗ #testSelectionIntervalNilUnselectsEverything (7ms)
 ✗ #testSettingTextManuallyAffectsTheUndoManager (3ms)
 ✗ #testSettingTextManuallyClearsTheUndoManager (3ms)
 ✗ #testShowPresenterShowsWidget (3ms)
 ✗ #testTextIsAlwaysString (4ms)
 ✗ #testTextWithStyle (8ms)
 ✗ #testVisibilityWithBlock (3ms)
 ✗ #testVisibilityWithBlockThatReturnsFalse (3ms)
 ✗ #testWithSyntaxHighlight (3ms)
 ✗ #testWithoutUndoRedoHistory (8ms)

  Executed 1564 Tests with 0 Failures and 46 Errors in 49.44s.
jecisc commented 9 months ago

Tests passed. I have to say that it is a little hard to review this one. Should we just merge?

estebanlm commented 9 months ago

no, I will merge. I need to merge with newtools and iceberg at the same time ;)