search

pharo-spec / Spec

Spec is a framework in Pharo for describing user interfaces.
MIT License
61 stars 63 forks source link

(Re)Moved Profile It command #1491

Closed JanBliznicenko closed 7 months ago

JanBliznicenko commented 7 months ago

Removed ProfileIt command as it is being moved to NewTools and implemented there. Part of efforts towards resolving issue https://github.com/pharo-project/pharo/issues/15795

JanBliznicenko commented 7 months ago

I believe those tests failed because it needed the changes in the pharo repository that were not merged until now. Could you re-run the failed action, please?

MarcusDenker commented 7 months ago

There are now failing:

 ✗ #testExternalBasicToolsDependencies (28ms)
 ✗ #testExternalIDEDependencies (69ms)
 ✗ #testExternalSpec2Dependencies (14ms)
 ✗ #testExternalUIDependencies (18ms)
JanBliznicenko commented 7 months ago

There are now failing:

 ✗ #testExternalBasicToolsDependencies (28ms)
 ✗ #testExternalIDEDependencies (69ms)
 ✗ #testExternalSpec2Dependencies (14ms)
 ✗ #testExternalUIDependencies (18ms)

I see. What do these tests tell us? That there are dependencies that are not being loaded by baselines?

Spec2's class SpCodeProfileItCommand now depends on ProfilerUI's class StProfilerPresenter (in order to open the profile presenter).

Maybe we can move the SpCodeProfileItCommand to the ProfilerUI package? ProfilerUI depends on Spec2 anyway. ProfilerUI's baseline BaselineOfProfilerUI does not depend on anything, not even Spec2, but all the ProfilerUI presenters depend on Spec2.

JanBliznicenko commented 7 months ago

If we move ProfilerUI to NewTools (https://github.com/pharo-project/pharo/pull/15772), it would make even more sense to move the command to ProfilerUI as well. I will modify this pull request to only remove the command from here.