pharo-spec / Spec

Spec is a framework in Pharo for describing user interfaces.
MIT License
61 stars 63 forks source link

display -> displayBlock #1499

Closed Ducasse closed 6 months ago

Ducasse commented 7 months ago
SpListPresenter >> display
    "Answer the display block that will transform the objects from `SpAbstractListPresenter>>#model` into a
     displayable string."

    ^ display

is super confusing.

We should rename it displayBlock.

Ducasse commented 7 months ago
SpListPresenter >> display
    "Answer the display block that will transform the model nodes into a displayable string."

    ^ displayBlock
Ducasse commented 7 months ago

We have few types so at least we should honored them. display is the screen and DIsplayObject already defines such a method to display an object.

Ducasse commented 6 months ago

To me the design behind display: and not displayBlock: is not nice because

Ducasse commented 6 months ago

I close this issue because I do not care anymore.