Cleanup/remove rename default spec to default layout refactoring

pharo-spec / Spec

Spec is a framework in Pharo for describing user interfaces.

MIT License

61 stars 63 forks source link

Cleanup/remove rename default spec to default layout refactoring #1515

Closed Ducasse closed 3 months ago

estebanlm commented 5 months ago

seems that clean up is not letting the package really empty ?

Ducasse commented 5 months ago

I do not know. We will check.

Ducasse commented 5 months ago

Now the PR just remove one package so I do not know how it could stay and be not empty.

Ducasse commented 5 months ago

@balsa-sarenac I have the impression that you removed too much. Why do we remove the full package? I would not remove

package: 'Spec2-Microdown' with: [ spec requires: #('SpecCore' 'Spec2-Adapters-Morphic') ];

Can you have a look?

balsa-sarenac commented 5 months ago

@Ducasse The package was empty after I have removed the class so I removed it as well. Packages that are left are: #('SpecCore' 'Spec2-Adapters-Morphic') I have only removed #('Spec2-Transformations')

Ducasse commented 5 months ago

Ok. Because on my machine it contains a lot of extensions.

jecisc commented 3 months ago

Should this be merged?

estebanlm commented 3 months ago

yeah, errors not related